blob: 2edf3965cd685359b9a9bd90f0d650f553fc4b89 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
|
# Helper function to convert flat array response to dict
proc hotkeys_array_to_dict {arr} {
set result {}
for {set i 0} {$i < [llength $arr]} {incr i 2} {
set key [lindex $arr $i]
set val [lindex $arr [expr {$i + 1}]]
dict set result $key $val
}
return $result
}
start_server {tags {"hotkeys"}} {
test {HOTKEYS START - METRICS required} {
r hello 3
catch {r hotkeys start} err
assert_match "*METRICS parameter is required*" $err
} {} {resp3}
test {HOTKEYS START - METRICS with CPU only} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 CPU]
r set key1 value1
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
assert [dict exists $result "total-cpu-time-user-ms"]
assert [dict exists $result "total-cpu-time-sys-ms"]
assert [dict exists $result "by-cpu-time"]
assert {![dict exists $result "total-net-bytes"]}
assert {![dict exists $result "by-net-bytes"]}
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - METRICS with NET only} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 NET]
r set key1 value1
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
assert [dict exists $result "total-net-bytes"]
assert [dict exists $result "by-net-bytes"]
assert {![dict exists $result "total-cpu-time-user-ms"]}
assert {![dict exists $result "total-cpu-time-sys-ms"]}
assert {![dict exists $result "by-cpu-time"]}
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - METRICS with both CPU and NET} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET]
r set key1 value1
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
assert [dict exists $result "total-cpu-time-user-ms"]
assert [dict exists $result "total-cpu-time-sys-ms"]
assert [dict exists $result "by-cpu-time"]
assert [dict exists $result "total-net-bytes"]
assert [dict exists $result "by-net-bytes"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - Error: session already started} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 CPU]
catch {r hotkeys start METRICS 1 NET} err
assert_match "*hotkey tracking session already in progress*" $err
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - Error: invalid METRICS count} {
r hello 3
catch {r hotkeys start METRICS 0} err
assert_match "*METRICS count*" $err
catch {r hotkeys start METRICS -1} err
assert_match "*METRICS count*" $err
} {} {resp3}
test {HOTKEYS START - Error: METRICS count mismatch} {
r hello 3
catch {r hotkeys start METRICS 2 CPU} err
assert_match "*METRICS count does not match number of metric types provided*" $err
catch {r hotkeys start METRICS 1 CPU NET} err
assert_match "*syntax error*" $err
catch {r hotkeys start METRICS 3 CPU NET} err
assert_match "*METRICS count*" $err
} {} {resp3}
test {HOTKEYS START - Error: METRICS invalid metrics} {
r hello 3
catch {r hotkeys start METRICS 1 GPU} err
assert_match "*METRICS no valid metrics*" $err
catch {r hotkeys start METRICS 2 GPU NYET} err
assert_match "*METRICS no valid metrics*" $err
# Allowing invalid metrics gives us forward-compatibility
assert_equal {OK} [r hotkeys start METRICS 2 GPU CPU]
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - Error: METRICS same parameter} {
r hello 3
catch {r hotkeys start METRICS 2 CPU CPU} err
assert_match "*METRICS CPU*" $err
catch {r hotkeys start METRICS 2 NET NET} err
assert_match "*METRICS NET*" $err
} {} {resp3}
test {HOTKEYS START - with COUNT parameter} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET COUNT 20]
for {set i 0} {$i < 30} {incr i} {
r set "key_$i" "value_$i"
}
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
set cpu_array [dict get $result "by-cpu-time"]
set net_array [dict get $result "by-net-bytes"]
set cpu_count [expr {[llength $cpu_array] / 2}]
set net_count [expr {[llength $net_array] / 2}]
assert_lessthan_equal $cpu_count 20
assert_lessthan_equal $net_count 20
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - Error: COUNT out of range} {
r hello 3
catch {r hotkeys start METRICS 1 CPU COUNT 0} err
assert_match "*COUNT must be between 1 and 64*" $err
catch {r hotkeys start METRICS 1 CPU COUNT 100} err
assert_match "*COUNT must be between 1 and 64*" $err
} {} {resp3}
test {HOTKEYS START - with DURATION parameter} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 CPU DURATION 1]
after 1500
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] eq "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
assert_equal 0 [dict get $result "tracking-active"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - with SAMPLE parameter} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SAMPLE 10]
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - Error: SAMPLE ratio invalid} {
r hello 3
catch {r hotkeys start METRICS 1 CPU SAMPLE 0} err
assert_match "*SAMPLE ratio must be positive*" $err
} {} {resp3}
test {HOTKEYS START - with SLOTS parameter} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SLOTS 2 0 5]
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS START - Error: SLOTS count mismatch} {
r hello 3
catch {r hotkeys start METRICS 1 CPU SLOTS 2 0} err
assert_match "*not enough slot numbers provided*" $err
} {} {resp3}
test {HOTKEYS START - Error: duplicate slots} {
r hello 3
catch {r hotkeys start METRICS 1 CPU SLOTS 2 0 0} err
assert_match "*duplicate slot number*" $err
} {} {resp3}
test {HOTKEYS STOP - basic functionality} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET]
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
assert_equal 0 [dict get $result "tracking-active"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS RESET - basic functionality} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 CPU]
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
# After reset, GET should return nil
set result [r hotkeys get]
assert_equal {} $result
} {} {resp3}
test {HOTKEYS RESET - Error: session in progress} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 CPU]
catch {r hotkeys reset} err
assert_match "*hotkey tracking session in progress, stop tracking first*" $err
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS GET - returns nil when not started} {
r hello 3
set result [r hotkeys get]
assert_equal {} $result
} {} {resp3}
test {HOTKEYS GET - sample-ratio field} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SAMPLE 5]
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
assert_equal 5 [dict get $result "sample-ratio"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS GET - selected-slots field} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SLOTS 2 0 5]
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
set slots [dict get $result "selected-slots"]
assert_equal 2 [llength $slots]
assert_equal 0 [lindex $slots 0]
assert_equal 5 [lindex $slots 1]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS GET - conditional fields with sample_ratio > 1 and selected slots} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SAMPLE 10 SLOTS 1 0]
r set key1 value1
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
# Should have conditional fields
assert [dict exists $result "sampled-command-selected-slots-ms"]
assert [dict exists $result "all-commands-selected-slots-ms"]
assert [dict exists $result "net-bytes-sampled-commands-selected-slots"]
assert [dict exists $result "net-bytes-all-commands-selected-slots"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS GET - no conditional fields with sample_ratio = 1} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SLOTS 1 0]
r set key1 value1
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
# Should NOT have sampled-commands fields (sample_ratio = 1)
assert {![dict exists $result "sampled-command-selected-slots-ms"]}
assert {![dict exists $result "net-bytes-sampled-commands-selected-slots"]}
# Should have all-commands-selected-slots fields
assert [dict exists $result "all-commands-selected-slots-ms"]
assert [dict exists $result "net-bytes-all-commands-selected-slots"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS - nested commands} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 1 NET]
r eval "redis.call('set', 'x', 1)" 1 x
r eval "redis.call('set', 'y', 1)" 1 y
r eval "redis.call('set', 'x', 2)" 1 x
r eval "redis.call('set', 'x', 3)" 1 x
set result [r hotkeys get]
set result [dict get $result "by-net-bytes"]
assert [dict exists $result "x"]
assert [dict exists $result "y"]
assert_equal {OK} [r hotkeys stop]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
test {HOTKEYS GET - no conditional fields without selected slots} {
r hello 3
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SAMPLE 10]
r set key1 value1
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
# Should NOT have selected-slots conditional fields
assert {![dict exists $result "sampled-command-selected-slots-ms"]}
assert {![dict exists $result "all-commands-selected-slots-ms"]}
assert {![dict exists $result "net-bytes-sampled-commands-selected-slots"]}
assert {![dict exists $result "net-bytes-all-commands-selected-slots"]}
# Should have all-slots fields
assert [dict exists $result "all-commands-all-slots-ms"]
assert [dict exists $result "net-bytes-all-commands-all-slots"]
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
foreach sample_ratio {1 100 500 1000} {
test "HOTKEYS detection with biased key access, sample ratio = $sample_ratio" {
r hello 3
# Generate 100 random keys
set all_keys {}
for {set i 0} {$i < 100} {incr i} {
lappend all_keys "key_[format %03d $i]"
}
# Choose 20 keys to bias towards. These will be out hot keys
set hot_keys {}
for {set i 0} {$i < 20} {incr i} {
lappend hot_keys [lindex $all_keys $i]
}
assert_equal {OK} [r hotkeys start METRICS 2 CPU NET SAMPLE $sample_ratio]
# Biasing towards the 20 chosen keys when sending commands
set total_commands 50000
for {set i 0} {$i < $total_commands} {incr i} {
set rand [expr {rand()}]
if {$rand < 0.8} {
set key [lindex $hot_keys [expr {int(rand() * 20)}]]
} else {
set key [lindex $all_keys [expr {20 + int(rand() * 80)}]]
}
r set $key "value_$i"
}
assert_equal {OK} [r hotkeys stop]
set result [r hotkeys get]
assert_not_equal $result {}
# Convert to dict if it's a flat array
if {[llength $result] > 0 && [lindex $result 0] ne "tracking-active"} {
set result [hotkeys_array_to_dict $result]
}
set cpu_time_array [dict get $result "by-cpu-time"]
set net_bytes_array [dict get $result "by-net-bytes"]
set returned_cpu_keys {}
for {set i 0} {$i < [llength $cpu_time_array]} {incr i 2} {
lappend returned_cpu_keys [lindex $cpu_time_array $i]
}
# Check that most of returned keys (based on cpu time) are from our
# hot_keys list
set num_returned_cpu [llength $returned_cpu_keys]
assert_lessthan_equal $num_returned_cpu 10
assert_morethan $num_returned_cpu 0
set res 0
foreach key $returned_cpu_keys {
if {[lsearch -exact $hot_keys $key] >= 0} {
incr res
}
}
assert_morethan $res 5
set returned_net_keys {}
for {set i 0} {$i < [llength $net_bytes_array]} {incr i 2} {
lappend returned_net_keys [lindex $net_bytes_array $i]
}
# Same as cpu-time but for net-bytes
set num_returned_net [llength $returned_net_keys]
assert_lessthan_equal $num_returned_net 10
assert_morethan $num_returned_net 0
set res_net 0
foreach key $returned_net_keys {
if {[lsearch -exact $hot_keys $key] >= 0} {
incr res_net
}
}
assert_morethan $res_net 5
assert_equal {OK} [r hotkeys reset]
} {} {resp3}
}
}
|
