blob: 5f7532c27475f8c05fd01a88e2e4121b4bb8e1d7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
|
set testmodule [file normalize tests/modules/list.so]
# The following arguments can be passed to args:
# i -- the number of inserts
# d -- the number of deletes
# r -- the number of replaces
# index -- the last index
# entry -- The entry pointed to by index
proc verify_list_edit_reply {reply argv} {
foreach {k v} $argv {
assert_equal [dict get $reply $k] $v
}
}
start_server {tags {"modules external:skip"}} {
r module load $testmodule
test {Module list set, get, insert, delete} {
r del k
assert_error {WRONGTYPE Operation against a key holding the wrong kind of value*} {r list.set k 1 xyz}
r rpush k x
# insert, set, get
r list.insert k 0 foo
r list.insert k -1 bar
r list.set k 1 xyz
assert_equal {foo xyz bar} [r list.getall k]
assert_equal {foo} [r list.get k 0]
assert_equal {xyz} [r list.get k 1]
assert_equal {bar} [r list.get k 2]
assert_equal {bar} [r list.get k -1]
assert_equal {foo} [r list.get k -3]
assert_error {ERR index out*} {r list.get k -4}
assert_error {ERR index out*} {r list.get k 3}
# remove
assert_error {ERR index out*} {r list.delete k -4}
assert_error {ERR index out*} {r list.delete k 3}
r list.delete k 0
r list.delete k -1
assert_equal {xyz} [r list.getall k]
# removing the last element deletes the list
r list.delete k 0
assert_equal 0 [r exists k]
}
test {Module list iteration} {
r del k
r rpush k x y z
assert_equal {x y z} [r list.getall k]
assert_equal {z y x} [r list.getall k REVERSE]
}
test {Module list insert & delete} {
r del k
r rpush k x y z
verify_list_edit_reply [r list.edit k ikikdi foo bar baz] {i 3 index 5}
r list.getall k
} {foo x bar y baz}
test {Module list insert & delete, neg index} {
r del k
r rpush k x y z
verify_list_edit_reply [r list.edit k REVERSE ikikdi foo bar baz] {i 3 index -6}
r list.getall k
} {baz y bar z foo}
test {Module list set while iterating} {
r del k
r rpush k x y z
verify_list_edit_reply [r list.edit k rkr foo bar] {r 2 index 3}
r list.getall k
} {foo y bar}
test {Module list set while iterating, neg index} {
r del k
r rpush k x y z
verify_list_edit_reply [r list.edit k reverse rkr foo bar] {r 2 index -4}
r list.getall k
} {bar y foo}
test {Module list - encoding conversion while inserting} {
r config set list-max-listpack-size 4
r del k
r rpush k a b c d
assert_encoding listpack k
# Converts to quicklist after inserting.
r list.edit k dii foo bar
assert_encoding quicklist k
assert_equal [r list.getall k] {foo bar b c d}
# Converts to listpack after deleting three entries.
r list.edit k ddd e
assert_encoding listpack k
assert_equal [r list.getall k] {c d}
}
test {Module list - encoding conversion while replacing} {
r config set list-max-listpack-size -1
r del k
r rpush k x y z
assert_encoding listpack k
# Converts to quicklist after replacing.
set big [string repeat "x" 4096]
r list.edit k r $big
assert_encoding quicklist k
assert_equal [r list.getall k] "$big y z"
# Converts to listpack after deleting the big entry.
r list.edit k d
assert_encoding listpack k
assert_equal [r list.getall k] {y z}
}
test {Module list - list entry and index should be updated when deletion} {
set original_config [config_get_set list-max-listpack-size 1]
# delete from start (index 0)
r del l
r rpush l x y z
verify_list_edit_reply [r list.edit l dd] {d 2 index 0 entry z}
assert_equal [r list.getall l] {z}
# delete from start (index -3)
r del l
r rpush l x y z
verify_list_edit_reply [r list.edit l reverse kkd] {d 1 index -3}
assert_equal [r list.getall l] {y z}
# # delete from tail (index 2)
r del l
r rpush l x y z
verify_list_edit_reply [r list.edit l kkd] {d 1 index 2}
assert_equal [r list.getall l] {x y}
# # delete from tail (index -1)
r del l
r rpush l x y z
verify_list_edit_reply [r list.edit l reverse dd] {d 2 index -1 entry x}
assert_equal [r list.getall l] {x}
# # delete from middle (index 1)
r del l
r rpush l x y z
verify_list_edit_reply [r list.edit l kdd] {d 2 index 1}
assert_equal [r list.getall l] {x}
# # delete from middle (index -2)
r del l
r rpush l x y z
verify_list_edit_reply [r list.edit l reverse kdd] {d 2 index -2}
assert_equal [r list.getall l] {z}
config_set list-max-listpack-size $original_config
}
test {Module list - KEYSIZES is updated as expected} {
proc run_cmd_verify_hist {cmd expOutput {retries 1}} {
proc K {} {return [string map { "db0_distrib_lists_items" "db0_LIST" "# Keysizes" "" " " "" "\n" "" "\r" "" } [r info keysizes] ]}
uplevel 1 $cmd
wait_for_condition 50 $retries {
$expOutput eq [K]
} else { fail "Expected: \n`$expOutput`\n Actual:\n`[K]`.\nFailed after command: $cmd" }
}
r select 0
# RedisModule_ListPush & RedisModule_ListDelete
run_cmd_verify_hist {r flushall} {}
run_cmd_verify_hist {r list.insert L1 0 foo} {db0_LIST:1=1}
run_cmd_verify_hist {r list.insert L1 0 bla} {db0_LIST:2=1}
run_cmd_verify_hist {r list.delete L1 0} {db0_LIST:1=1}
run_cmd_verify_hist {r list.delete L1 0} {}
# RedisModule_ListSet & RedisModule_ListDelete
run_cmd_verify_hist {r list.insert L1 0 foo} {db0_LIST:1=1}
run_cmd_verify_hist {r list.set L1 0 bar} {db0_LIST:1=1}
run_cmd_verify_hist {r list.set L1 0 baz} {db0_LIST:1=1}
run_cmd_verify_hist {r list.delete L1 0} {}
# Check lazy expire
r debug set-active-expire 0
run_cmd_verify_hist {r list.insert L1 0 foo} {db0_LIST:1=1}
run_cmd_verify_hist {r pexpire L1 1} {db0_LIST:1=1}
run_cmd_verify_hist {after 5} {db0_LIST:1=1}
r debug set-active-expire 1
run_cmd_verify_hist {after 5} {} 50
}
test "Unload the module - list" {
assert_equal {OK} [r module unload list]
}
}
# A basic test that exercises a module's list commands under cluster mode.
# Currently, many module commands are never run even once in a clustered setup.
# This test helps ensure that basic module functionality works correctly and that
# the KEYSIZES histogram remains accurate and that insert & delete was tested.
set testmodule [file normalize tests/modules/list.so]
set modules [list loadmodule $testmodule]
start_cluster 2 2 [list tags {external:skip cluster modules} config_lines [list loadmodule $testmodule enable-debug-command yes]] {
test "Module list - KEYSIZES is updated correctly in cluster mode" {
for {set srvid -2} {$srvid <= 0} {incr srvid} {
set instance [srv $srvid client]
# Assert consistency after each command
$instance DEBUG KEYSIZES-HIST-ASSERT 1
for {set i 0} {$i < 50} {incr i} {
for {set j 0} {$j < 4} {incr j} {
catch {$instance list.insert "list:$i" $j "item:$j"} e
if {![string match "OK" $e]} {assert_match "*MOVED*" $e}
}
}
for {set i 0} {$i < 50} {incr i} {
for {set j 0} {$j < 4} {incr j} {
catch {$instance list.delete "list:$i" 0} e
if {![string match "OK" $e]} {assert_match "*MOVED*" $e}
}
}
# Verify also that instance is responsive and didn't crash on assert
assert_equal [$instance dbsize] 0
}
}
}
|